Grant manage_threads to java.desktop for Tika #134454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
>non-issue
auto-backport
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
force-pushed
the
disposer-entitlements
branch
from
32fe444 to
9b33eb5
Compare
ldematte
reviewed
Sep 10, 2025
test/framework/src/main/java/org/elasticsearch/bootstrap/TestScopeResolver.java
Outdated
Show resolved
Hide resolved
...entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/HardcodedEntitlements.java
Outdated
Show resolved
Hide resolved
.../framework/src/main/java/org/elasticsearch/entitlement/runtime/policy/TestPolicyManager.java
Outdated
Show resolved
Hide resolved
Fortunately, the JDK is still modular even if the tests are run sans modules, so we can use the module API to identify the packages in every system module.
ldematte
approved these changes
Sep 11, 2025
This was referenced Sep 11, 2025
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Sep 11, 2025
* Grant manage_threads to java.desktop for Tika * Produce a PolicyScope for excluded system modules. Fortunately, the JDK is still modular even if the tests are run sans modules, so we can use the module API to identify the packages in every system module. * TODO with Jira link
💔 Backport failed
You can use sqren/backport to manually backport by running |
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Sep 11, 2025
* Grant manage_threads to java.desktop for Tika * Produce a PolicyScope for excluded system modules. Fortunately, the JDK is still modular even if the tests are run sans modules, so we can use the module API to identify the packages in every system module. * TODO with Jira link
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 11, 2025
* Grant manage_threads to java.desktop for Tika * Produce a PolicyScope for excluded system modules. Fortunately, the JDK is still modular even if the tests are run sans modules, so we can use the module API to identify the packages in every system module. * TODO with Jira link
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 11, 2025
* Grant manage_threads to java.desktop for Tika * Produce a PolicyScope for excluded system modules. Fortunately, the JDK is still modular even if the tests are run sans modules, so we can use the module API to identify the packages in every system module. * TODO with Jira link
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Sep 11, 2025
* Grant manage_threads to java.desktop for Tika * Produce a PolicyScope for excluded system modules. Fortunately, the JDK is still modular even if the tests are run sans modules, so we can use the module API to identify the packages in every system module. * TODO with Jira link
|
Backport stragglers are in #134559 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 11, 2025
* Grant manage_threads to java.desktop for Tika * Produce a PolicyScope for excluded system modules. Fortunately, the JDK is still modular even if the tests are run sans modules, so we can use the module API to identify the packages in every system module. * TODO with Jira link
|
@prdoyle @ldematte I tried a simple fix to add more permissions, but it does not seem to resolve the issue. Can you please consider reverting this PR temporarily or work on a fix? |
julian-elastic
added a commit
that referenced
this pull request
Sep 11, 2025
This reverts commit 9b41320.
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Sep 11, 2025
…ic#134559) * Grant manage_threads to java.desktop for Tika * Produce a PolicyScope for excluded system modules. Fortunately, the JDK is still modular even if the tests are run sans modules, so we can use the module API to identify the packages in every system module. * TODO with Jira link
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
…ic#134544) * Grant manage_threads to java.desktop for Tika * Produce a PolicyScope for excluded system modules. Fortunately, the JDK is still modular even if the tests are run sans modules, so we can use the module API to identify the packages in every system module. * TODO with Jira link
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 11, 2025
…34580) * Grant manage_threads to java.desktop for Tika * Produce a PolicyScope for excluded system modules. Fortunately, the JDK is still modular even if the tests are run sans modules, so we can use the module API to identify the packages in every system module. * TODO with Jira link
|
I'll have a look and will fix asap @julian-elastic |
|
Oh, I missed #134578 |
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
…ic#134544) * Grant manage_threads to java.desktop for Tika * Produce a PolicyScope for excluded system modules. Fortunately, the JDK is still modular even if the tests are run sans modules, so we can use the module API to identify the packages in every system module. * TODO with Jira link
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Sep 23, 2025
BASE=41fea9d8a715b1e2ffb668c3cf54c6c9645f0331 HEAD=135d74b33ba9f1ce2b0e61fa5fb2a39a3763c688 Branch=main
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Oct 2, 2025
BASE=41fea9d8a715b1e2ffb668c3cf54c6c9645f0331 HEAD=135d74b33ba9f1ce2b0e61fa5fb2a39a3763c688 Branch=main
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Oct 7, 2025
BASE=41fea9d8a715b1e2ffb668c3cf54c6c9645f0331 HEAD=135d74b33ba9f1ce2b0e61fa5fb2a39a3763c688 Branch=main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When processing PDFs, Apache Tika calls pdfbox, which creates a
MemoryCacheInputStream, which (until JDK 26) usessun.java2d.Disposer, whose static initializer creates a cleanup thread. SinceDisposeris in thejava.desktopmodule, which we exclude from system modules, the entitlement check formanage_threadsfails.Workaround
For the time being, just have the server grant
manage_threadstojava.desktop. This is a fairly broad grant, so we'd like to find a more surgical solution, but this problem is observed in production right now, so we need a fix.Stack trace